Nockma backend: translate trace to %puts hints
#3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
nock-trace-hint
branch
2 times, most recently
from
2275baa to
209e81a
Compare
lukaszcz
requested review from
paulcadman and
janmasrovira
and removed request for
paulcadman
paulcadman
approved these changes
Sep 26, 2024
paulcadman
force-pushed
the
nock-trace-hint
branch
from
cf438a1 to
7baa642
Compare
|
Should we merge this or wait? Because this depends on an unmerged branch in anoma |
Good point, let me check if the unmerged branch merges cleanly into base. |
We should wait - because the corresponding Anoma PR does not merge cleanly after the 'defactor'. |
janmasrovira
force-pushed
the
nock-trace-hint
branch
from
7baa642 to
f62e839
Compare
|
The Anoma change got merged - so we can merge this now: |
paulcadman
force-pushed
the
nock-trace-hint
branch
from
f62e839 to
7829e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%puts hintfeature in Nock backend debug mode #3022