Named arguments for record projections #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukaszcz
commented
Nov 14, 2024
•
lukaszcz
commented
- Closes Consistent named application syntax with record projections #3054
- Adds named argument signatures for generated record projections.
lukaszcz
force-pushed
the
named-arguments-for-record-projections
branch
from
fff4d38 to
5f4657f
Compare
lukaszcz
force-pushed
the
named-arguments-for-record-projections
branch
from
4f6ff53 to
b51b40f
Compare
paulcadman
previously approved these changes
Nov 15, 2024
janmasrovira
requested changes
Nov 15, 2024
| @@ -1725,6 +1736,103 @@ checkSections sec = topBindings helper | |||
| p2' | |||
| ) | |||
|
|
|||
| mkProjectionType :: ExpressionType 'Parsed -> ExpressionType 'Parsed | |||
There was a problem hiding this comment.
most of this code could go to Juvix.Compiler.Concrete.Gen
janmasrovira
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.