Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes duplicated governance proposal types #202

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Removes duplicated governance proposal types #202

merged 2 commits into from
Nov 9, 2023

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Nov 8, 2023

This update matches the specs with the actual code. More specifically, we only have one PGFProposal variant that encompass both the StewardFundingProposal and the FundingProposal

cwgoes
cwgoes approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack modulo nit

packages/specs/pages/governance/proposal.mdx Outdated Show resolved Hide resolved
@bengtlofgren bengtlofgren merged commit 25f8c75 into master Nov 9, 2023
@bengtlofgren bengtlofgren deleted the grarco/fix-governance-specs branch November 9, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@Fraccaman Fraccaman Awaiting requested review from Fraccaman

@bengtlofgren bengtlofgren Awaiting requested review from bengtlofgren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grarco @cwgoes @bengtlofgren