-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove borsh schemas and the encoding spec #2682
Conversation
might need to rebuild wasms for tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
==========================================
+ Coverage 53.38% 53.76% +0.38%
==========================================
Files 302 301 -1
Lines 103403 102602 -801
==========================================
- Hits 55198 55162 -36
+ Misses 48205 47440 -765 ☔ View full report in Codecov by Sentry. |
* origin/tiago/rm-borsh-schemas: Changelog for #2682 Stop building `namada_encoding_spec` in CI Remove borsh schema feat from Cargo manifest Remove borsh schema implementations Remove `namada_encoding_spec`
Would keeping the |
we'll be keeping borsh schemas in Namada, as they might be handy in the future |
Describe your changes
Borsh schemas were only depended upon by the
namada_encoding_spec
crate. Therefore, we can remove schemas, which were an unstable feature in borsh, anyway.Indicate on which release or other PRs this topic is based on
v0.31.5
Checklist before merging to
draft