Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: print last stake ration and improve msg on zero inflation #4241

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

tzemanovic
Copy link
Member

Describe your changes

When the PoS inflation is 0 the client printed PoS inflation and rewards are not currently enabled. assuming it's not enabled. This PR adds additional query to print last staked ratio which may cause the inflation to go to 0 when its over the target_staked_ratio and changes the message to No PoS inflation and rewards tokens were minted. that can apply to either case.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (7169a3f) to head (612a69c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4241      +/-   ##
==========================================
- Coverage   74.59%   74.58%   -0.01%     
==========================================
  Files         342      342              
  Lines      108771   108771              
==========================================
- Hits        81135    81132       -3     
- Misses      27636    27639       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 17, 2025
@mergify mergify bot merged commit 9eb747c into main Jan 17, 2025
25 checks passed
@mergify mergify bot deleted the tomas/client-staking-rewards-query branch January 17, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli client merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants