Skip to content

Commit

Permalink
fix staticcheck faulures in 'cmd' pkg
Browse files Browse the repository at this point in the history
  • Loading branch information
carlory committed Dec 16, 2019
1 parent e680ad7 commit 2fe8207
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions cmd/kube-proxy/app/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ func (s *ProxyServer) Run() error {
w.Header().Set("X-Content-Type-Options", "nosniff")
fmt.Fprintf(w, "%s", s.ProxyMode)
})
//lint:ignore SA1019 See the Metrics Stability Migration KEP
proxyMux.Handle("/metrics", legacyregistry.Handler())
if s.EnableProfiling {
routes.Profiling{}.Install(proxyMux)
Expand Down
2 changes: 1 addition & 1 deletion cmd/linkcheck/links.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ var (
)

func newWalkFunc(invalidLink *bool, client *http.Client) filepath.WalkFunc {
return func(filePath string, info os.FileInfo, err error) error {
return func(filePath string, info os.FileInfo, initErr error) error {
hasSuffix := false
for _, suffix := range *fileSuffix {
hasSuffix = hasSuffix || strings.HasSuffix(info.Name(), suffix)
Expand Down
3 changes: 2 additions & 1 deletion cmd/preferredimports/preferredimports.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ import (
"go/format"
"go/parser"
"go/token"
"golang.org/x/crypto/ssh/terminal"
"io/ioutil"
"log"
"os"
"path/filepath"
"regexp"
"sort"
"strings"

"golang.org/x/crypto/ssh/terminal"
)

var (
Expand Down
2 changes: 0 additions & 2 deletions hack/.staticcheck_failures
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
cluster/images/etcd-version-monitor
cluster/images/etcd/migrate
cmd/kube-proxy/app
cmd/linkcheck
pkg/controller/daemon
pkg/controller/deployment
pkg/controller/disruption
Expand Down

0 comments on commit 2fe8207

Please sign in to comment.