Fix failure of vm reconfiguration with enabled virt_based_security #1848
Conversation
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 31s |
|
The ci check failed due to "License not available to perform the operation" - so it's not a problem with this change. |
|
@mariolenz Could you have a look at this? |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 35s |
|
recheck |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 36s |
|
CI checks look good ping @ihumster @mariolenz |
|
Any chance merging this @mariolenz @ihumster ? |
|
@Yannik I'm afraid (my) priority at the moment is to release 4.0.0 soon in order to get it into the Ansible community package 9.0.0. In order to do this, there are breaking changes I have to implement during the next two weeks or so. If I don't, I'll have to wait another year until the 5.0 release of the collection. I understand that this is frustrating for you, but the difference is that you (hopefully) just have to wait another two or three weeks, while other people needing changes to modules that are breaking would have to wait another year if I don't get them implemented / merged in time. I hope you understand. |
|
@mariolenz Any chance to get this reviewed now? :) |
|
@Yannik Code is OK, but need correct formatting of the change. Create changelog fragment |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 9m 43s |
|
@ihumster Done |
|
@ihumster Looks OK to me now. What do you think, should we merge? |
|
@mariolenz Of course! |
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 9m 34s |
softwarefactory-project-zuul
bot
merged commit 6bde749
into
ansible-collections:main
…nsible-collections#1848) Fix failure of vm reconfiguration with enabled virt_based_security SUMMARY VM reconfiguration is currently broken when virt_based_security is configured due to checking for vbsEnabled on the wrong object. ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest Reviewed-by: Mario Lenz <[email protected]>
Fix PR 1848 changelog SUMMARY Fix #1848 changelog. ISSUE TYPE Docs Pull Request
…_security (#1980) stable-3.x: Fix failure of vm reconfiguration with enabled virt_based_security SUMMARY VM reconfiguration is currently broken when virt_based_security is configured due to checking for vbsEnabled on the wrong object. ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Backport #1848
|
Thanks @mariolenz ! |
SUMMARY
VM reconfiguration is currently broken when
virt_based_securityis configured due to checking forvbsEnabledon the wrong object.ISSUE TYPE
COMPONENT NAME
vmware_guest