add standard vmware_argument_spec, fix issue #1977 #1978
Conversation
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 9m 45s |
There was a problem hiding this comment.
It looks like this is a breaking change. Playbooks using host wouldn't work anymore.
Maybe we should start with changing the argument spec (and documentation) from host with an alias of hostname to hostname with an alias of host and deprecate the latter. And then we could start using vmware_argument_spec().
Your changes look OK but as far as I can see they would be breakin.
|
For backward compatibility purposes, you can add the alias |
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 9m 42s |
softwarefactory-project-zuul
bot
merged commit 42062ca
into
ansible-collections:main
|
Apparently the "host" deprecation just fell off? My builds are failing using "host" at this point. If it has, the documentation for VSPHERE_FILE needs to be updated, all examples are still showing "host". I'll add an issue. |
Fixes #2110 SUMMARY Follow-up to #1978 fixing the examples in the documentation. ISSUE TYPE Docs Pull Request COMPONENT NAME vsphere_file cc @rgadwagner Reviewed-by: Alexander Nikitin <[email protected]>
SUMMARY
Fix #1977 . Add standard vmware_argument_spec() function.
ISSUE TYPE
COMPONENT NAME
vsphere_file