Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_host_facts - related datacenter #1994

Conversation

Nina2244
Copy link
Contributor

@Nina2244 Nina2244 commented Feb 7, 2024

SUMMARY

Add the possibility to get the related datacenter.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_host_facts.py

ADDITIONAL INFORMATION

@alinabuzachis
Copy link
Contributor

recheck

@ihumster
Copy link
Collaborator

ihumster commented Feb 7, 2024

@Nina2244 Judging by the sanity tests, there are disagreements in argument_specs and documentation. Needs to be fixed

@Nina2244 Nina2244 changed the title vmware_host_facts-related datacenter vmware_host_facts - related datacenter Feb 7, 2024
@mariolenz
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

@ihumster The code LGTM now. What do you think, should we merge if the CI succeeds?

@ihumster
Copy link
Collaborator

@mariolenz Yes, I think we can merge it.

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolenz mariolenz added feature This issue/PR relates to a feature request mergeit labels Feb 13, 2024
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0582f8c1ce15442c93aabc23450f4a7b

✔️ ansible-tox-linters SUCCESS in 10m 17s
✔️ build-ansible-collection SUCCESS in 8m 44s
✔️ ansible-galaxy-importer SUCCESS in 3m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4ce1264 into ansible-collections:main Feb 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants