Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCBx resource module #507

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bsun-sudo
Copy link

@bsun-sudo bsun-sudo commented Feb 3, 2025

SUMMARY

DCBX_INTERFACES module implementation

GitHub Issues

N/A

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_dcbx_interfaces

related PR

ansible-network/resource_module_models#296

OUTPUT

Regression Test HTML report:

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

unit test
regression test
playbook

@@ -1,6 +1,6 @@
#
# -*- coding: utf-8 -*-
# Copyright 2025 Dell Inc. or its subsidiaries. All Rights Reserved
# Copyright 2024 Dell Inc. or its subsidiaries. All Rights Reserved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copyright should stay 2025

Suggested change
# Copyright 2024 Dell Inc. or its subsidiaries. All Rights Reserved
# Copyright 2025 Dell Inc. or its subsidiaries. All Rights Reserved

@haemanthisree
Copy link

I have pushed the changes to merge the DCBx global and interfaces modules. Will close out the global DCBx PRs.
Regression run results :-
dcbx_regression_ansible.pdf

@stalabi1 stalabi1 changed the title add ansible for interface DCBx configuration Add DCBx resource module Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants