Install unzip into the image #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is necessary for a builtin to function. AWX-EE should probably have it included. 👍 |
austlane
reviewed
Feb 21, 2023
|
I was not sure, so I made it bulletproof. If debian-based systems are not required to support, I also propose #180, so that it does not confuse others (like it confused me). |
|
@Himura2la Sorry for the delay here. I agree this probably should be included since an ansible-core module depends on it. We've redone how the EE gets built now, could rebase your PR and instead add the line to the system requirements in Thanks much! |
shanemcd
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #120