-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to centos:stream9-minimal
#246
base: devel
Are you sure you want to change the base?
Conversation
execution-environment.yml
Outdated
git-lfs [platform:rpm] | ||
sshpass [platform:rpm] | ||
rsync [platform:rpm] | ||
epel-release [platform:rpm] | ||
python-unversioned-command [platform:rpm] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package always links to python3.9
on el9. Replaced with alternatives
commands below.
exclude: | ||
system: | ||
- python3 | ||
- python3-devel | ||
- python3-rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires ansible/ansible-builder#664
EDIT: ansible/ansible-builder#664 has been merged! 🎉
@austlane this is awesome, is this PR ready? |
This PR works as-is 👍 But I'd imagine it shouldn't be merged until ansible/ansible-builder#664 is merged into ansible-builder, depending directly on a PR seems hacky. |
1e0743f
to
9486970
Compare
@@ -2,8 +2,13 @@ | |||
version: 3 | |||
images: | |||
base_image: | |||
name: quay.io/centos/centos:stream9 | |||
name: quay.io/centos/centos:stream9-minimal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any particular reason for switching from stream9 to stream9-minimal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stream9-minimal
images do not include python at all out of the box, which allows us to avoid unnecessarily bundling two versions of python in awx-ee (3.9 + 3.11). That was the primary motivation.
I'll be rebasing this PR now that #207 has been merged 👍 I still think this approach is worth consideration to keep the EE light / avoid shipping two Pythons. EDIT: Rebased :) |
Also removes `subversion`, as it hard-depends upon `python3.9`.
9486970
to
3f5c49a
Compare
centos:stream9-minimal
and python3.11
centos:stream9-minimal
This PR switches the base image to
centos:stream9-minimal
which usesmicrodnf
and does not bundle Python3.9, allowing us to ship a final image without Python 3.9 installed at all.Also removes
subversion
, as it hard-depends uponpython3.9
, no love lost.This is another take on #207 and #244EDIT: Rebased after #207 was merged.
EDIT: ansible/ansible-builder#664 has been merged. This PR is ready for review.