-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disconnect logic to fill in role parents #15462
base: devel
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
The checks here are actually looking fairly okay-ish to me. Just need to get some integration testing results to confirm that nothing unexpected is happening. YOLO 10152 |
Question: should we also remove the role parents/children sub-endpoint with this change? Lines 4464 to 4489 in 7ed0eee
They won't be correct after this (I'd expect they'll have nothing. |
^ answer is trending "yes" |
SUMMARY
For code removals after RBAC changes, this is my first pass, since it is the most mechanistic change.
A role (in the old system) has both parent roles and ancestor roles tracked in relationships. We have already disconnected the logic for rebuilding ancestors but rebuilding parents is more minimal... although still maintained via connected signals.
The goal of this PR is to gut the signals for role parent rebuilding. This gets weird in a few cases, like how editing related ForeignKey fields can change role parents. I want to also be thorough about tracing de-referenced methods and deleting them.
ping @hakbailey
ISSUE TYPE
COMPONENT NAME