correct 400/404 status codes

anstiftung · Feb 5, 2024 · a318efe · a318efe
1 parent 18cdcd3
commit a318efe
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Controller/WorkshopsController.php b/src/Controller/WorkshopsController.php
@@ -405,7 +405,7 @@ public function getWorkshopsWithCityFilter() {
 
         $city = $this->request->getQuery('city');
         if ($city === null || strlen($city) < 3) {
-            throw new NotFoundException('city not passed or invalid (min 3 chars)');
+            return $this->response->withStatus(400)->withType('json')->withStringBody(json_encode('city not passed or invalid (min 3 chars)'));
         }
 
         $workshops = $this->Workshop->find('all',
@@ -422,6 +422,10 @@ public function getWorkshopsWithCityFilter() {
         ],
         order: ['Workshops.name' => 'asc']);
 
+        if ($workshops->count() == 0) {
+            return $this->response->withStatus(404)->withType('json')->withStringBody(json_encode('no workshops found'));
+        }
+
         $preparedWorkshops = [];
         foreach($workshops as $workshop) {