add return types

anstiftung · Jan 15, 2025 · a883ea2 · a883ea2
1 parent 74a974b
commit a883ea2
Show file tree

Hide file tree

Showing 32 changed files with 314 additions and 221 deletions.
diff --git a/config/Migrations/20200107095607_SqlModeFixes.php b/config/Migrations/20200107095607_SqlModeFixes.php
@@ -4,7 +4,7 @@
 
 class SqlModeFixes extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
         $this->execute("
             ALTER TABLE `blocked_workshop_slugs` CHANGE `url` `url` VARCHAR(255) CHARACTER SET utf8 COLLATE utf8_general_ci NULL DEFAULT NULL, CHANGE `status` `status` TINYINT(4) NULL DEFAULT NULL;

diff --git a/config/Migrations/20200210102652_AddDefaultDefectDescription.php b/config/Migrations/20200210102652_AddDefaultDefectDescription.php
@@ -5,7 +5,7 @@
 
 class AddDefaultDefectDescription extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
         $this->execute("ALTER TABLE `info_sheets` CHANGE `defect_description` `defect_description` TEXT CHARACTER SET utf8 COLLATE utf8_general_ci NULL DEFAULT NULL;");
     }

diff --git a/config/Migrations/20210325100602_OnlineEvent.php b/config/Migrations/20210325100602_OnlineEvent.php
@@ -5,7 +5,7 @@
 
 class OnlineEvent extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
         $this->execute("ALTER TABLE `events` ADD `is_online_event` TINYINT(4) UNSIGNED NOT NULL DEFAULT '0' AFTER `workshop_uid`;");
     }

diff --git a/config/Migrations/20210719093143_AddAdditionalInfoSheetData.php b/config/Migrations/20210719093143_AddAdditionalInfoSheetData.php
@@ -5,7 +5,7 @@
 
 class AddAdditionalInfoSheetData extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
 
         $this->execute("

diff --git a/config/Migrations/20210816093411_RenameTable.php b/config/Migrations/20210816093411_RenameTable.php
@@ -5,7 +5,7 @@
 
 class RenameTable extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
         $this->execute("RENAME TABLE form_field_options_extra_info TO form_field_options_extra_infos;");
     }

diff --git a/config/Migrations/20210818075040_AddIso3CodeToCountries.php b/config/Migrations/20210818075040_AddIso3CodeToCountries.php
@@ -5,7 +5,7 @@
 
 class AddIso3CodeToCountries extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
         $sql = "CREATE TABLE IF NOT EXISTS `tmp_countries` (
               `id` int(11) NOT NULL AUTO_INCREMENT,

diff --git a/config/Migrations/20210927124302_GeoDataForUsers.php b/config/Migrations/20210927124302_GeoDataForUsers.php
@@ -7,7 +7,7 @@
 
 class GeoDataForUsers extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
 
         $this->execute("ALTER TABLE `users` ADD `lat` DOUBLE NULL DEFAULT NULL AFTER `country_code`, ADD `lng` DOUBLE NULL DEFAULT NULL AFTER `lat`;");

diff --git a/config/Migrations/20220321084056_ChangeZeroDatesForMySql8.php b/config/Migrations/20220321084056_ChangeZeroDatesForMySql8.php
@@ -6,7 +6,7 @@
 class ChangeZeroDatesForMySql8 extends AbstractMigration
 {
 
-    public function change()
+    public function change(): void
     {
 
         $tables = [

diff --git a/config/Migrations/20220404070045_Knowledge.php b/config/Migrations/20220404070045_Knowledge.php
@@ -5,7 +5,7 @@
 
 class Knowledge extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
         $sql = "ALTER TABLE `roots` CHANGE `object_type` `object_type` ENUM('pages','users','posts','workshops','events','coaches','votings','photos','info_sheets','knowledges') CHARACTER SET ascii COLLATE ascii_bin NULL DEFAULT NULL;";
         $this->execute($sql);

diff --git a/config/Migrations/20221128184445_RemoveNewsletter.php b/config/Migrations/20221128184445_RemoveNewsletter.php
@@ -5,7 +5,7 @@
 
 class RemoveNewsletter extends AbstractMigration
 {
-    public function change()
+    public function change(): void
     {
         $this->execute("DROP table newsletters;");
     }

diff --git a/phpstan.neon b/phpstan.neon
@@ -15,7 +15,6 @@ parameters:
         - message: '#Access to an undefined property .*#'
         - message: '#Cannot access property .*#'
         - message: '#Call to an undefined method Authorization\\IdentityInterface::*.#'
-        - message: '#Method .* has no return type specified.#'
         - message: '#Method .* has parameter .* with no type specified.#'
         - message: '#Method .* has parameter .* with no value type specified in iterable type array.#'
         - message: '#Method .* return type has no value type specified in iterable type array.#'

diff --git a/src/View/Helper/MenuHelper.php b/src/View/Helper/MenuHelper.php
@@ -9,7 +9,7 @@
 class MenuHelper extends Helper
 {
 
-    public function render($array, $options)
+    public function render($array, $options): string
     {
         $tmpMenu = '<ul id="'.$options['id'].'" class="'.$options['class'].'">';
         if (!empty($options['header'])) {
@@ -25,7 +25,7 @@ public function render($array, $options)
         return $tmpMenu;
     }
 
-    public function buildPageMenu($pages)
+    public function buildPageMenu($pages): array
     {
 
         $menu = [];
@@ -58,7 +58,7 @@ public function buildPageMenu($pages)
         return $menu;
     }
 
-    private function buildMenuItem($item, $index)
+    private function buildMenuItem($item, $index): string
     {
 
         $liClass = [];
@@ -89,7 +89,7 @@ private function buildMenuItem($item, $index)
         return $tmpMenuItem;
     }
 
-    private function renderMenuElement($slug, $name, $style = '', $class = [], $target = '')
+    private function renderMenuElement($slug, $name, $style = '', $class = [], $target = ''): string
     {
 
         if ($style != '') {