Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that Meilisearch secret is used in workflows #1400

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jorgepiloto
Copy link
Member

Continuation of #1302, fixes #1327 by adding the variable at step level. Everything is properly configured in the conf.py file and I can see the Meilisearch indices for PyDPF working as expected.

The latest stable documentation does not contain any reference to Meilisearch in its HTML, meaning that the MEILISEARCH_PUBLIC_API_KEY was not available when the docs built. I suspect that the cmd is starting a new shell with a new env, loosing track of the environment declared in the docs.yml.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9966263) 86.52% compared to head (472abd1) 86.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
+ Coverage   86.52%   86.91%   +0.38%     
==========================================
  Files          81       81              
  Lines        9513     9506       -7     
==========================================
+ Hits         8231     8262      +31     
+ Misses       1282     1244      -38     

@PProfizi PProfizi merged commit 0d6481e into master Feb 5, 2024
40 checks passed
@PProfizi PProfizi deleted the fix/search-bar branch February 5, 2024 16:12
@MaxJPRey
Copy link
Contributor

MaxJPRey commented Feb 5, 2024

Thanks @jorgepiloto for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyDPF documentation search doesn't work
3 participants