-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use tox in ci #2031
ci: use tox in ci #2031
Conversation
Moving to "Ready for review" so I can observe workflow runs. |
452c771
to
2d7b82b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2031 +/- ##
==========================================
- Coverage 88.61% 86.44% -2.17%
==========================================
Files 90 90
Lines 10231 10231
==========================================
- Hits 9066 8844 -222
- Misses 1165 1387 +222 |
5f45198
to
f766ee6
Compare
f766ee6
to
6c010c6
Compare
a2f6f53
to
99072f7
Compare
Adding this issue too: |
95be4df
to
6d6fa88
Compare
d6739c4
to
cb79b6c
Compare
Thanks @moe-ad, does that mean we cannot have coverage with the proposed changes? |
@PProfizi I can't really say for now. I am still trying out different things to see if we can get coverage to work normally. |
@jorgepiloto @PProfizi looks like we are good to go. |
Thanks for the very big effort here, @moe-ad. All the research you performed is super valuable and will prevent us from this tricky issue in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is impressive. Just approved it. Thanks a lot, @moe-ad.
Related to #296