Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use tox in ci #2031

Merged
merged 65 commits into from
Feb 5, 2025
Merged

ci: use tox in ci #2031

merged 65 commits into from
Feb 5, 2025

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Jan 22, 2025

Related to #296

@moe-ad
Copy link
Contributor Author

moe-ad commented Jan 22, 2025

Moving to "Ready for review" so I can observe workflow runs.

@moe-ad moe-ad marked this pull request as ready for review January 22, 2025 13:44
@moe-ad moe-ad changed the title feat: use tox in ci ci: use tox in ci Jan 22, 2025
@moe-ad moe-ad force-pushed the feat/use-tox-in-ci branch from 452c771 to 2d7b82b Compare January 22, 2025 14:02
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (06567a3) to head (2364517).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
- Coverage   88.61%   86.44%   -2.17%     
==========================================
  Files          90       90              
  Lines       10231    10231              
==========================================
- Hits         9066     8844     -222     
- Misses       1165     1387     +222     

@moe-ad moe-ad requested a review from a team as a code owner January 24, 2025 11:13
@moe-ad moe-ad force-pushed the feat/use-tox-in-ci branch 2 times, most recently from 5f45198 to f766ee6 Compare January 24, 2025 12:44
@moe-ad moe-ad force-pushed the feat/use-tox-in-ci branch from f766ee6 to 6c010c6 Compare January 24, 2025 12:56
@moe-ad moe-ad force-pushed the feat/use-tox-in-ci branch 6 times, most recently from a2f6f53 to 99072f7 Compare January 27, 2025 09:06
@moe-ad
Copy link
Contributor Author

moe-ad commented Feb 3, 2025

@moe-ad moe-ad force-pushed the feat/use-tox-in-ci branch from 95be4df to 6d6fa88 Compare February 4, 2025 10:44
@moe-ad moe-ad force-pushed the feat/use-tox-in-ci branch from d6739c4 to cb79b6c Compare February 4, 2025 11:45
@PProfizi
Copy link
Contributor

PProfizi commented Feb 4, 2025

Yeah. pytest-cov is the culprit and not any of the other plugins. Another related issue:

Thanks @moe-ad, does that mean we cannot have coverage with the proposed changes?

@moe-ad
Copy link
Contributor Author

moe-ad commented Feb 4, 2025

@PProfizi I can't really say for now. I am still trying out different things to see if we can get coverage to work normally.

@moe-ad
Copy link
Contributor Author

moe-ad commented Feb 4, 2025

@jorgepiloto @PProfizi looks like we are good to go.

tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@jorgepiloto
Copy link
Member

Thanks for the very big effort here, @moe-ad. All the research you performed is super valuable and will prevent us from this tricky issue in the future.

tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@moe-ad moe-ad requested a review from jorgepiloto February 5, 2025 10:19
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is impressive. Just approved it. Thanks a lot, @moe-ad.

@moe-ad moe-ad merged commit acffb5f into master Feb 5, 2025
45 checks passed
@moe-ad moe-ad deleted the feat/use-tox-in-ci branch February 5, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants