Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated code for DPF 252_daily on master #2050

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pyansys-ci-bot
Copy link
Collaborator

An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.

@pyansys-ci-bot pyansys-ci-bot requested a review from a team as a code owner February 4, 2025 00:16
@pyansys-ci-bot pyansys-ci-bot added the server-sync DO NOT USE, Related to automatic synchronization with the server label Feb 4, 2025
Comment on lines +69 to +71
expanded_meshed_region : MeshedRegion or MeshesContainer, optional
Mesh expanded, use if cyclic expansion is to
be done.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardopeixotocoelho I think this may require a little clarification: what I understand is that when requesting result data expanded, you can provide a mesh to this pin so that the mesh expansion is not done by the source operator, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi Yes, you have it right. If the user provides the expanded mesh to this pin we just read it instead of expanding it in DPF

@PProfizi
Copy link
Contributor

PProfizi commented Feb 4, 2025

Waiting on #2053

@pyansys-ci-bot pyansys-ci-bot force-pushed the maint/update_code_for_252_daily_on_master branch from e3e8641 to bba76bc Compare February 4, 2025 14:34
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (06567a3) to head (b76a57a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
- Coverage   87.50%   86.36%   -1.15%     
==========================================
  Files          90       90              
  Lines       10231    10231              
==========================================
- Hits         8953     8836     -117     
- Misses       1278     1395     +117     

@PProfizi
Copy link
Contributor

PProfizi commented Feb 4, 2025

Latest fix for ambiguous Inputs.connect only resolved the issue for retro. @rafacanton

@@ -65,12 +65,6 @@ class accu_eqv_creep_strain(Operator):
requested_location : str, optional
Requested location nodal, elemental or
elementalnodal
read_cyclic : int, optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafacanton @ricardopeixotocoelho is this normal? Why do we lose a pin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @ricardopeixotocoelho did the digging job to only support cyclic for the variables where cyclic is allowed. So this was a previous bug, basically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server-sync DO NOT USE, Related to automatic synchronization with the server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants