-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generated code for DPF 252_daily on master #2050
base: master
Are you sure you want to change the base?
Conversation
expanded_meshed_region : MeshedRegion or MeshesContainer, optional | ||
Mesh expanded, use if cyclic expansion is to | ||
be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardopeixotocoelho I think this may require a little clarification: what I understand is that when requesting result data expanded, you can provide a mesh to this pin so that the mesh expansion is not done by the source operator, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PProfizi Yes, you have it right. If the user provides the expanded mesh to this pin we just read it instead of expanding it in DPF
Waiting on #2053 |
e3e8641
to
bba76bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2050 +/- ##
==========================================
- Coverage 87.50% 86.36% -1.15%
==========================================
Files 90 90
Lines 10231 10231
==========================================
- Hits 8953 8836 -117
- Misses 1278 1395 +117 |
Latest fix for ambiguous |
@@ -65,12 +65,6 @@ class accu_eqv_creep_strain(Operator): | |||
requested_location : str, optional | |||
Requested location nodal, elemental or | |||
elementalnodal | |||
read_cyclic : int, optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafacanton @ricardopeixotocoelho is this normal? Why do we lose a pin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @ricardopeixotocoelho did the digging job to only support cyclic for the variables where cyclic is allowed. So this was a previous bug, basically
An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.