Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Extend create port with name #505

Merged
merged 2 commits into from
May 23, 2024
Merged

FEATURE: Extend create port with name #505

merged 2 commits into from
May 23, 2024

Conversation

gkorompi
Copy link
Collaborator

No description provided.

@gkorompi gkorompi linked an issue May 23, 2024 that may be closed by this pull request
edb.hfss.create_circuit_port_on_pin creates only one circuit port if used multiple times #479
Closed
2 tasks
svandenb-dev
svandenb-dev requested changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the test. Just add a simple test in the existing one I guess. Otherwise with doing that even small things we will decrease the codecov

@SMoraisAnsys SMoraisAnsys changed the title FIX: add name FEATURE: Extend create port with name May 23, 2024
svandenb-dev
svandenb-dev approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkorompi gkorompi merged commit 80bcc37 into main May 23, 2024
25 checks passed
@gkorompi gkorompi deleted the create_port branch May 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svandenb-dev svandenb-dev svandenb-dev approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

edb.hfss.create_circuit_port_on_pin creates only one circuit port if used multiple times
3 participants
@gkorompi @svandenb-dev @SMoraisAnsys