Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Point terminal layer getter function #965

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Jan 8, 2025

Duplicates PR #945 which was created from a fork.


The getter function for layer of the point terminal always returned the top layer name irrespective of where the terminal was located. This has been fixed.
The getter function of location has also been refactored to simply implementation.

Fixes #944

The layer getter property of the point terminal always returned the top layer name
irrespective of where the terminal was located. This has been fixed.

(cherry picked from commit 265b4b3)
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (fc0c8fa) to head (7a68a8a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   82.68%   82.66%   -0.02%     
==========================================
  Files         160      160              
  Lines       21098    21100       +2     
==========================================
- Hits        17444    17443       -1     
- Misses       3654     3657       +3     

@SMoraisAnsys
Copy link
Collaborator Author

@skandak-ansys We had a problem with the VM used in CICD. Now things should be working again :)

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 67dcb66 into main Jan 13, 2025
29 of 30 checks passed
@svandenb-dev svandenb-dev deleted the refactor/point-terminal branch January 13, 2025 14:40
@hui-zhou-a
Copy link
Collaborator

@svandenb-dev the layer property should be in PointTerminal class not Terminal

@skandak-ansys
Copy link
Collaborator

skandak-ansys commented Jan 13, 2025

@hui-zhou-a layer property is available for both PointTerminal and PadstackInstanceTerminal. So I added a try-except to capture terminals where layer property is invalid and left it inside Terminal class, where it initially was.

@hui-zhou-a
Copy link
Collaborator

@skandak-ansys logger.error should be replaced by Raise RuntimeError. Logging the error will hide the problem.

@hui-zhou-a
Copy link
Collaborator

@skandak-ansys GetParameter should only be called in PointTerminal and PadstackInstanceTermal class. This is a code structural problem. I will fix it in another PR. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer property of point terminal always returns topmost stackup layer
5 participants