-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Point terminal layer getter function #965
Conversation
The layer getter property of the point terminal always returned the top layer name irrespective of where the terminal was located. This has been fixed. (cherry picked from commit 265b4b3)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 82.68% 82.66% -0.02%
==========================================
Files 160 160
Lines 21098 21100 +2
==========================================
- Hits 17444 17443 -1
- Misses 3654 3657 +3 |
@skandak-ansys We had a problem with the VM used in CICD. Now things should be working again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@svandenb-dev the layer property should be in PointTerminal class not Terminal |
@hui-zhou-a |
@skandak-ansys logger.error should be replaced by Raise RuntimeError. Logging the error will hide the problem. |
@skandak-ansys GetParameter should only be called in PointTerminal and PadstackInstanceTermal class. This is a code structural problem. I will fix it in another PR. Thanks for your contribution! |
Duplicates PR #945 which was created from a fork.
The getter function for
layer
of the point terminal always returned the top layer name irrespective of where the terminal was located. This has been fixed.The getter function of
location
has also been refactored to simply implementation.Fixes #944