Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/adaptive templates geometry classes #153

Merged
merged 25 commits into from
Aug 17, 2023
Merged

Feat/adaptive templates geometry classes #153

merged 25 commits into from
Aug 17, 2023

Conversation

matthewAnsys
Copy link
Collaborator

Adaptive templates functionality

@github-actions github-actions bot added the enhancement New features or code improvements label Aug 3, 2023
@jgsdavies jgsdavies added the Core API Requires changes to Motor-CAD API. (Needs to be done by Motor-CAD development team) label Aug 4, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 7, 2023
jgsdavies
jgsdavies requested changes Aug 7, 2023
View reviewed changes
doc/source/methods/geometry_functions.rst Show resolved Hide resolved
geom_json_example.json Outdated Show resolved Hide resolved
src/ansys/motorcad/core/geometry.py Outdated Show resolved Hide resolved
src/ansys/motorcad/core/methods/adaptive_geometry.py Outdated Show resolved Hide resolved
src/ansys/motorcad/core/methods/adaptive_geometry.py Outdated Show resolved Hide resolved
tests/test_geometry.py Outdated Show resolved Hide resolved
tests/test_geometry.py Outdated Show resolved Hide resolved
tests/test_geometry.py Outdated Show resolved Hide resolved
tests/test_geometry.py Outdated Show resolved Hide resolved
tests/test_geometry.py Outdated Show resolved Hide resolved
@jgsdavies
Copy link
Collaborator

Also can you build docs with tox -e doc and verify that the docstrings you are writing look correct in html docs

@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #153 (330e816) into main (6b62933) will increase coverage by 0.40%.
Report is 4 commits behind head on main.
The diff coverage is 83.83%.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   81.92%   82.33%   +0.40%     
==========================================
  Files          17       18       +1     
  Lines         996     1200     +204     
==========================================
+ Hits          816      988     +172     
- Misses        180      212      +32

@jgsdavies jgsdavies merged commit 345cf1c into main Aug 17, 2023
17 checks passed
@jgsdavies jgsdavies deleted the feat/adaptive_templates_geometry_classes branch August 17, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsdavies jgsdavies jgsdavies approved these changes

@ravi-ansys ravi-ansys Awaiting requested review from ravi-ansys ravi-ansys is a code owner

@JackB-Ansys JackB-Ansys Awaiting requested review from JackB-Ansys JackB-Ansys is a code owner

Assignees

@jgsdavies jgsdavies

@matthewAnsys matthewAnsys

Labels
Core API Requires changes to Motor-CAD API. (Needs to be done by Motor-CAD development team) documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewAnsys @jgsdavies