Split and repeat on boundary method #352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect point on the arc is always returned.
…n_boundary_method
Added class method for Region boundary_split()
…. Uses rotate instead.
…d_repeat_on_boundary_method # Conflicts: # src/ansys/motorcad/core/geometry.py # tests/test_geometry.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 86.65% 82.69% -3.96%
==========================================
Files 20 21 +1
Lines 2098 2277 +179
==========================================
+ Hits 1818 1883 +65
- Misses 280 394 +114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new region method to split region 1 when it overhangs region 2 and rotate the overhanging portion of region 1. Devised to account for regions that overhang the rotor or stator boundary to simplify the process of mirroring or repeating drawing of a region to the other side of the rotor or stator.
(Illustration to be added)