Fix ECE EMag twin builder export #413
Open
+313
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackB-Ansys
requested review from
jgsdavies,
ravi-ansys and
matthewAnsys
as code owners
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 21 21
Lines 2366 2366
=======================================
Hits 2044 2044
Misses 322 322 |
…EMag_Twin_Builder_Export
…EMag_Twin_Builder_Export
…EMag_Twin_Builder_Export
|
Removed myself as a reviewer |
ravi-ansys
previously approved these changes
Nov 20, 2024
james-packer
requested changes
Dec 19, 2024
| file_id = open(sml_file, "w") | ||
| file_id.write("%6s\r\n" % "MODELDEF ECER_Model1") | ||
| file_id.write("%6s\r\n" % "MODELDEF ECE_e8") |
There was a problem hiding this comment.
Could we get this from the mot file name, instead of hard coding? (Will need to be careful of non-alphanumeric characters in the mot file name, as these may not be valid in the SML, for example spaces, special characters or non-ascii characters)
| @@ -554,7 +718,7 @@ def read_parameters(json_file): | |||
| file_id.write( | |||
| "%6s\r\n" | |||
| % ( | |||
| "INTERN NDSRC PECER_Model1 N0:=GND," | |||
| "INTERN NDSRC PECE_e8 N0:=GND," | |||
There was a problem hiding this comment.
As above, could PECE_e8 be made less hard coded?
| @@ -563,7 +727,7 @@ def read_parameters(json_file): | |||
| "%6s\r\n" % " ( QUANT:={ AM0.I, AM1.I, AM2.I }," | |||
| ' SRC:={ isrc, isrc, isrc, isrc }, TableData:="\ ' | |||
| ) | |||
| file_id.write("%6s" % ".MODEL ECER_Model1_table pwl TABLE=(") | |||
| file_id.write("%6s" % ".MODEL ECE_e8_table pwl TABLE=(") | |||
There was a problem hiding this comment.
As above, could this be less hard coded?
…EMag_Twin_Builder_Export
and get the number of torque points per cycle from the JSON file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usability updates and additional detail added, restructuring of the example