Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve dual scrollbar issue and flickering on initial load #485

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LofiSu
Copy link

@LofiSu LofiSu commented Jan 18, 2025

Fix: Resolve dual scrollbar issue and flickering on initial load

  • Adjusted container styles to ensure overflow: auto is set, allowing scrollbars to appear only when content overflows.
  • Updated InfiniteScroll component to hide unnecessary scrollbars by setting style={{ overflow: 'hidden' }}.
  • Verified scrollableTarget is correctly set to prevent style conflicts.
  • Ensured no conflicting CSS styles are affecting the scroll behavior.

OriginBug:#465

image

Summary by CodeRabbit

  • 样式调整
    • 修改了无限滚动组件的溢出(overflow)样式属性
    • 将滚动容器的溢出样式从 'scroll' 更改为 'auto'
    • 为无限滚动组件添加了新的样式属性,将溢出设置为 'hidden'

Copy link
Contributor

coderabbitai bot commented Jan 18, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (9)
  • components/attachments/__tests__/__snapshots__/demo-extend.test.ts.snap is excluded by !**/*.snap
  • components/attachments/__tests__/__snapshots__/demo.test.tsx.snap is excluded by !**/*.snap
  • components/bubble/__tests__/__snapshots__/demo-extend.test.ts.snap is excluded by !**/*.snap
  • components/bubble/__tests__/__snapshots__/demo.test.ts.snap is excluded by !**/*.snap
  • components/conversations/__tests__/__snapshots__/demo-extend.test.ts.snap is excluded by !**/*.snap
  • components/conversations/__tests__/__snapshots__/demo.test.ts.snap is excluded by !**/*.snap
  • components/sender/__tests__/__snapshots__/index.test.tsx.snap is excluded by !**/*.snap
  • components/thought-chain/__tests__/__snapshots__/demo-extend.test.ts.snap is excluded by !**/*.snap
  • components/thought-chain/__tests__/__snapshots__/demo.test.ts.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

概述

浏览

这个变更修改了无限滚动组件(InfiniteScroll)的样式属性,具体调整了溢出(overflow)的处理方式。样式对象中的 overflow 属性从 'scroll' 变更为 'auto',并为组件添加了新的样式属性,将溢出设置为 'hidden'。这些更改可能会影响内容的滚动和可见性行为。

变更

文件 变更摘要
components/conversations/demo/infinite-load.tsx 修改样式对象的 overflow 属性,从 'scroll' 改为 'auto';为 InfiniteScroll 组件添加新的样式属性,设置溢出为 'hidden'

诗歌

🐰 滚动的兔子,样式轻舞
溢出变幻,如魔法般轻柔
autohidden 共舞
组件跳跃,内容悄然流
代码的兔子,调皮一笑 🌈


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jan 18, 2025

Preview is ready

Copy link

Walkthrough

This pull request addresses the dual scrollbar issue and flickering on initial load by adjusting container styles. It ensures that overflow: auto is set for containers, allowing scrollbars to appear only when content overflows. The InfiniteScroll component is updated to hide unnecessary scrollbars by setting style={{ overflow: 'hidden' }}. Additionally, it verifies that scrollableTarget is correctly set to prevent style conflicts.

Changes

File Summary
components/conversations/demo/infinite-load.tsx Changed overflow from scroll to auto for container styles and added style={{ overflow: 'hidden' }} to InfiniteScroll component to resolve dual scrollbar issue.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/conversations/demo/infinite-load.tsx (1)

62-62: 为 InfiniteScroll 组件添加 overflow: 'hidden' 完美解决了双滚动条问题!

这个改动与容器的 overflow: auto 相互配合,确保只显示一个滚动条。建议添加注释说明这个样式的用途,以便其他开发者理解。

建议添加如下注释:

        scrollableTarget="scrollableDiv"
-        style={{ overflow: 'hidden' }}
+        // 防止出现双滚动条,与容器的 overflow: auto 配合使用
+        style={{ overflow: 'hidden' }}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5380eb5 and 28c02ec.

📒 Files selected for processing (1)
  • components/conversations/demo/infinite-load.tsx (2 hunks)
🔇 Additional comments (1)
components/conversations/demo/infinite-load.tsx (1)

19-19: 将容器的 overflow 属性从 'scroll' 更改为 'auto' 是个很好的改进!

这个改动可以确保只在内容超出容器尺寸时才显示滚动条,避免了不必要的滚动条出现。

Copy link

codecov bot commented Jan 21, 2025

Bundle Report

Bundle size has no change ✅

@YumoImer
Copy link
Collaborator

@LofiSu test CI 挂了,需要更新下 snap

@LofiSu
Copy link
Author

LofiSu commented Jan 22, 2025

@LofiSu test CI 挂了,需要更新下 snap

snap是什么

@LofiSu
Copy link
Author

LofiSu commented Jan 23, 2025

执行了一下npm test -- -u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants