-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resolve dual scrollbar issue and flickering on initial load #485
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (9)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 Walkthrough概述浏览这个变更修改了无限滚动组件( 变更
诗歌
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses the dual scrollbar issue and flickering on initial load by adjusting container styles. It ensures that Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/conversations/demo/infinite-load.tsx (1)
62-62
: 为 InfiniteScroll 组件添加 overflow: 'hidden' 完美解决了双滚动条问题!这个改动与容器的 overflow: auto 相互配合,确保只显示一个滚动条。建议添加注释说明这个样式的用途,以便其他开发者理解。
建议添加如下注释:
scrollableTarget="scrollableDiv" - style={{ overflow: 'hidden' }} + // 防止出现双滚动条,与容器的 overflow: auto 配合使用 + style={{ overflow: 'hidden' }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/conversations/demo/infinite-load.tsx
(2 hunks)
🔇 Additional comments (1)
components/conversations/demo/infinite-load.tsx (1)
19-19
: 将容器的 overflow 属性从 'scroll' 更改为 'auto' 是个很好的改进!这个改动可以确保只在内容超出容器尺寸时才显示滚动条,避免了不必要的滚动条出现。
Bundle ReportBundle size has no change ✅ |
@LofiSu test CI 挂了,需要更新下 snap |
snap是什么 |
执行了一下npm test -- -u |
Fix: Resolve dual scrollbar issue and flickering on initial load
overflow: auto
is set, allowing scrollbars to appear only when content overflows.InfiniteScroll
component to hide unnecessary scrollbars by settingstyle={{ overflow: 'hidden' }}
.scrollableTarget
is correctly set to prevent style conflicts.OriginBug:#465
Summary by CodeRabbit
'scroll'
更改为'auto'
'hidden'