introduce new train method for sq #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHT129
added
the
kind/improvement
LHT129
force-pushed
the
sq8_train
branch
3 times, most recently
from
b94ca10 to
75b9517
Compare
ShawnShawnYou
approved these changes
Dec 20, 2024
inabao
reviewed
Dec 20, 2024
| auto ignore_count = static_cast<uint64_t>(static_cast<float>(count - 1) * 0.001); | ||
|
|
||
| for (uint64_t i = 0; i < dim_; ++i) { | ||
| upper_bound[i] = std::numeric_limits<float>::lowest(); |
There was a problem hiding this comment.
Unnecessary initialization
| std::priority_queue<float, std::vector<float>, std::greater<>> heap_max; | ||
| std::priority_queue<float, std::vector<float>, std::less<>> heap_min; | ||
| heap_max.emplace(upper_bound[i]); | ||
| heap_min.emplace(lower_bound[i]); |
There was a problem hiding this comment.
No need for initial values in advance
| uint64_t count, | ||
| float* upper_bound, | ||
| float* lower_bound) const { | ||
| auto ignore_count = static_cast<uint64_t>(static_cast<float>(count - 1) * 0.001); |
There was a problem hiding this comment.
what happened when count = 0?
Signed-off-by: LHT129 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.