Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "concurrent add test" for hnsw/hgraph #243

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Dec 23, 2024

  • rename recall to expected_recall
  • hgraph not enable SUPPORT_ADD_CONCURRENT feature, so the concurrent add test is skip actually

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Dec 23, 2024
@LHT129 LHT129 self-assigned this Dec 23, 2024
- rename recall to expected_recall
- hgraph not enable SUPPORT_ADD_CONCURRENT feature, so the concurrent
  add test is skip actually

Signed-off-by: LHT129 <[email protected]>
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 4f7e21c into antgroup:main Dec 25, 2024
7 checks passed
@LHT129 LHT129 deleted the add_threads branch December 25, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L version/0.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants