Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable asan for coverage test #285

Merged
merged 1 commit into from
Dec 31, 2024
Merged

disable asan for coverage test #285

merged 1 commit into from
Dec 31, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Dec 30, 2024

No description provided.

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Dec 30, 2024
@LHT129 LHT129 self-assigned this Dec 30, 2024
@LHT129 LHT129 force-pushed the coverage branch 10 times, most recently from 41f554a to 223e12f Compare December 30, 2024 06:54
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 116 files with indirect coverage changes

@LHT129 LHT129 marked this pull request as ready for review December 31, 2024 03:08
wxyucs
wxyucs approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 changed the title [wip] disable asan for coverage test disable asan for coverage test Dec 31, 2024
inabao
inabao approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 8b990ad into main Dec 31, 2024
10 checks passed
@LHT129 LHT129 deleted the coverage branch December 31, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxyucs wxyucs wxyucs approved these changes

@inabao inabao inabao approved these changes

@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LHT129 @wxyucs @inabao