Implement the merge function in HNSW #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inabao
requested review from
ShawnShawnYou,
LHT129,
wxyucs and
jiaweizone
as code owners
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 91.24% 91.55% +0.31%
==========================================
Files 151 160 +9
Lines 9859 9905 +46
==========================================
+ Hits 8996 9069 +73
+ Misses 863 836 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
LHT129
reviewed
Feb 24, 2025
| struct ODescentParameter : public Parameter { | ||
| public: | ||
| void | ||
| FromJson(const JsonType& json) override; |
added 2 commits
February 24, 2025 19:12
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
jiaweizone
reviewed
Feb 24, 2025
src/impl/odescent_graph_builder.h
Outdated
| Allocator* allocator_; | ||
|
|
||
| const ODescentParameterPtr odescent_parameter_; |
There was a problem hiding this comment.
minor: use short name odescent_param_
src/impl/odescent_graph_builder.cpp
Outdated
| if (neighbors.size() > max_degree_) { | ||
| neighbors.resize(max_degree_); | ||
| if (neighbors.size() > odescent_parameter_->max_degree) { | ||
| neighbors.resize(odescent_parameter_->max_degree); |
There was a problem hiding this comment.
Q: Only do shrink operation ?
src/impl/odescent_graph_builder.h
Outdated
| float alpha, | ||
| int64_t turn, | ||
| float sample_rate, | ||
| struct IdsSequence { |
There was a problem hiding this comment.
Can replace to std::vector ?
Signed-off-by: jinjiabao.jjb <[email protected]>
ShawnShawnYou
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#318