This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Allow for custom inline styles to be set on the button #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdomegg
approved these changes
Sep 27, 2021
The implementation of the new style merging is to use a function, named 'addKeysTo' which takes 2 objects, copies a reference to the target object, and assigns each style from the user defined style object too it. The reason that I am using a function for this operation is to follow the DRY principle, and to minimize the bundle size.
This is to keep in line with the general layout of the project, instead of defining the function in google-login.js
|
I just tested using the rest operator instead of |
TheBestTvarynka
approved these changes
Feb 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tinkering and discovered that the styles are intended to not be altered.
The change uses
Array.forEach()andObject.keys(), both of which are IE 9 compatible.The test suites pass with the amended snapshot set to reflect the new user defined style prop.
Issue link
Edit:
After forking the repo and using the new inline style capabilities, I came to the conclusion that it might also be useful to be able to customise the style states, to keep a consistent design for all button states.
The new commit allows the following:
Before
After