Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Library loading rework #12

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Native Library loading rework #12

merged 7 commits into from
Aug 30, 2024

Conversation

antithesis-shomik
Copy link
Contributor

Slightly invasive patch to:

  1. Fix how we load voidstar with local makes
  2. Fix how we load the JNI native library and what error handling in the failure case looks like
  3. Create a new marker to indicate library load and replace the "hasPath" pattern
  4. Adjusted the interface for Coverage to be used by the FFIHandler

herzogp
herzogp approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@herzogp herzogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@herzogp herzogp merged commit c45b0eb into main Aug 30, 2024
1 check passed
@herzogp herzogp deleted the fix-patchelf-path branch August 30, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herzogp herzogp herzogp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antithesis-shomik @herzogp