Skip to content

Commit

Permalink
[Darwin] Remove StartupMetricsCollection from fw init
Browse files Browse the repository at this point in the history
- MTRFrameworkInit was initializing metrics collector but if
  controller factory is never created tracing backend will crash on
  system exit.
- Remove the unbalanced init and rely on controller to register and
  unregister the backend
  • Loading branch information
anush-apple committed Mar 27, 2024
1 parent f15d3ae commit 9fce0ff
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/darwin/Framework/CHIP/MTRFramework.mm
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

#import "MTRFramework.h"
#import "MTRMetricsCollector.h"

#include <dispatch/dispatch.h>
#include <lib/support/CHIPMem.h>
Expand All @@ -35,8 +34,5 @@ void MTRFrameworkInit()
// Suppress CHIP logging until we actually need it for redirection
// (see MTRSetLogCallback()). Logging to os_log is always enabled.
chip::Logging::SetLogFilter(chip::Logging::kLogCategory_None);

// Startup metrics collection and tracing framework
StartupMetricsCollection();
});
}

0 comments on commit 9fce0ff

Please sign in to comment.