fix: avoid setting duplicate log attrs

Remove context=main from the core logger; context must be set only by components. Why? slog doesn't override attributes by default but duplicate them in the output instead. Let's not deal with custom handlers, etc. and follow slog design
anycable · Feb 26, 2024 · 2ce7245 · 2ce7245
1 parent 3cf30a7
commit 2ce7245
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cli/cli.go b/cli/cli.go
@@ -104,7 +104,7 @@ func (r *Runner) checkAndSetDefaults() error {
 			return errorx.Decorate(err, "failed to initialize default logger")
 		}
 
-		r.log = slog.With("context", "main").With("nodeid", r.config.ID)
+		r.log = slog.With("nodeid", r.config.ID)
 	}
 
 	err := r.config.LoadPresets(r.log)

diff --git a/rpc/rpc.go b/rpc/rpc.go
@@ -506,7 +506,7 @@ func defaultDialer(conf *Config, l *slog.Logger) (pb.RPCClient, ClientHelper, er
 
 	const grpcServiceConfig = `{"loadBalancingPolicy":"round_robin"}`
 
-	state := &grpcClientHelper{log: l.With("context", "grpc")}
+	state := &grpcClientHelper{log: l.With("impl", "grpc")}
 
 	dialOptions := []grpc.DialOption{
 		grpc.WithKeepaliveParams(kacp),