fix: do not track pongs during command execution

Long-running commands may cause pongs blocking, thus, dropping clients connections

node/node.go

@@ -162,9 +162,11 @@ func (n *Node) Instrumenter() metrics.Instrumenter {
 // execute the command (if recognized)
 func (n *Node) HandleCommand(s *Session, msg *common.Message) (err error) {
 	s.Log.Debug("incoming message", "data", msg)
+
+	s.keepalive()
+
 	switch msg.Command {
 	case "pong":
-		s.handlePong(msg)
 	case "subscribe":
 		_, err = n.Subscribe(s, msg)
 	case "unsubscribe":
@@ -179,6 +181,10 @@ func (n *Node) HandleCommand(s *Session, msg *common.Message) (err error) {
 		err = fmt.Errorf("unknown command: %s", msg.Command)
 	}
 
+	// Reset pong timer after the message has been processed
+	// (so we don't disconnect the client if processing the message took too long)
+	s.resetPong()
+
 	return
 }
 

node/session.go

@@ -673,12 +673,22 @@ func newPingMessage(format string) *common.PingMessage {
 	return (&common.PingMessage{Type: "ping", Message: ts})
 }
 
-func (s *Session) handlePong(msg *common.Message) {
+func (s *Session) keepalive() {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+
+	if s.pongTimer == nil {
+		return
+	}
+
+	s.pongTimer.Stop()
+}
+
+func (s *Session) resetPong() {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
 	if s.pongTimer == nil {
-		s.Log.Debug("unexpected pong received")
 		return
 	}