Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnprocessedTransactionStorage #4604

Merged
merged 17 commits into from
Mar 4, 2025
Merged

Remove UnprocessedTransactionStorage #4604

merged 17 commits into from
Mar 4, 2025
+458 −1,809

Conversation

ksolana
Copy link

@ksolana ksolana commented Jan 23, 2025

Towards: #3357

@ksolana ksolana changed the title ThreadLocalUnprocessedPackets Remove UnprocessedTransactionStorage Jan 23, 2025
@ksolana ksolana marked this pull request as ready for review January 24, 2025 13:43
apfitzge
apfitzge reviewed Jan 28, 2025
View reviewed changes
apfitzge
apfitzge reviewed Jan 28, 2025
View reviewed changes
core/src/banking_stage/consumer.rs
@@ -2171,348 +2093,6 @@ mod tests {
Blockstore::destroy(ledger_path.path()).unwrap();
}

#[test]
fn test_consume_buffered_packets() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a similar test of functionality for votes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to #5072

@ksolana ksolana force-pushed the legacy_banking branch 2 times, most recently from 8a90c01 to 826b995 Compare February 26, 2025 05:49
@apfitzge apfitzge mentioned this pull request Jan 23, 2025
Open
4 tasks
@apfitzge
Copy link

we should be able to remove ImmutableDeserializedPacket more easily once this is merged.

@ksolana ksolana force-pushed the legacy_banking branch 2 times, most recently from 19b2098 to 00ec190 Compare February 27, 2025 17:18
@ksolana ksolana mentioned this pull request Feb 28, 2025
Open
3 tasks
apfitzge
apfitzge reviewed Feb 28, 2025
View reviewed changes
apfitzge
apfitzge reviewed Mar 3, 2025
View reviewed changes
core/src/banking_stage/unprocessed_packet_batches.rs
@@ -89,26 +84,6 @@ impl UnprocessedPacketBatches {
self.message_hash_to_transaction.clear();
}

/// Insert new `deserialized_packet_batch` into inner `MinMaxHeap<DeserializedPacket>`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type UnprocessedPacketBatches does not need to exist anymore

Copy link
Author

@ksolana ksolana Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Only DeserializedPacket remains in this file. Should we rename the file or wait for the multi_iterator thing to be removed as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeserializedPacket is also useless 😄 but we can leave that for a follow-up PR because it involves a bunch of small changes.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^it is useless because it wraps a Arc<ImmutableDeserializedPacket> with a forwarded bool; which is no longer part of banking stage's responsibilities

@ksolana ksolana merged commit 98d868a into anza-xyz:master Mar 4, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apfitzge apfitzge apfitzge approved these changes

@tao-stones tao-stones Awaiting requested review from tao-stones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksolana @apfitzge