refactor: add LeaderSchedule trait #4973
Merged
+251
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
reviewed
Mar 4, 2025
jstarry
force-pushed
the
refactor/leader-schedule-trait
branch
from
0d79307 to
6f4c835
Compare
Ha don't get too excited. This is just the refactor, still have to implement the new vote keyed schedule in a follow up. This approach is going to add more code than the other way. |
t-nelson
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
3x red lines. winner in my book!
Ha don't get too excited. This is just the refactor, still have to implement the new vote keyed schedule in a follow up. This approach is going to add more code than the other way.
lol. those will be green lines tho and we'll get to delete the old version eventually!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to add another type of leader schedule introduced by SIMD-0180
Summary of Changes
LeaderScheduleVariantLeaderScheduleas type alias forBox<dyn LeaderScheduleVariant>Fixes #