Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply 3515: use SendTransactionService::new_with_client in rpc #5111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KirillLykov
Copy link

Problem

Use SendTransactionService::new_with_client everywhere and deprecated new and new_with_config.

This PR finished reapplying changes from reverted #3515

Summary of Changes

Copy link

mergify bot commented Mar 2, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @KirillLykov.

@KirillLykov KirillLykov changed the title Use STS new_with_client everywhere Reapply 3515: use SendTransactionService::new_with_client in rpc Mar 2, 2025
@KirillLykov KirillLykov marked this pull request as ready for review March 2, 2025 19:02
@KirillLykov
Copy link
Author

CI failure seems to be unrelated to my changes

@KirillLykov KirillLykov requested a review from bw-solana March 2, 2025 19:07
@KirillLykov KirillLykov force-pushed the klykov/add-back-rest-of-3515 branch from 56ccfca to 9eb96a3 Compare March 3, 2025 10:11
@KirillLykov KirillLykov added the v2.2 Backport to v2.2 branch label Mar 3, 2025
Copy link

mergify bot commented Mar 3, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.2 Backport to v2.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant