-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If the account length is zero, no data region is present #5122
Conversation
The Firedancer team maintains a line-for-line reimplementation of the |
52c6d48
to
588be3a
Compare
This only affects unaligned programs, as for aligned programs the resize area address will match the account region address if the data length is zero.
588be3a
to
797913c
Compare
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
This only affects unaligned programs, as for aligned programs the resize area address will match the account region address if the data length is zero. (cherry picked from commit 561023d)
This only affects unaligned programs, as for aligned programs the resize area address will match the account region address if the data length is zero. (cherry picked from commit 561023d)
This only affects unaligned programs, as for aligned programs the resize area address will match the account region address if the data length is zero. (cherry picked from commit 561023d)
This only affects unaligned programs, as for aligned programs the resize area address will match the account region address if the data length is zero.
Problem
When an account is length zero, then there is no account data region. Memcpy's across the data should be permitted since there is no data region.
Found by @topointon-jump
Summary of Changes
Fixes #