Add SBPFv1 tests to the CI pipeline #5126
Open
+66
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
force-pushed
the
v1-test
branch
3 times, most recently
from
74c6878 to
dd3fbc8
Compare
LucasSte
changed the title
Lichtso
reviewed
Mar 5, 2025
| for i in 10..MAX_CALL_DEPTH { | ||
| let stack = &mut stack[i * STACK_FRAME_SIZE..][..STACK_FRAME_SIZE]; | ||
| assert!(stack == &ZEROS[..STACK_FRAME_SIZE], "stack not zeroed"); | ||
| stack.fill(42); | ||
| } | ||
|
|
||
| #[cfg(feature = "dynamic-frames")] |
There was a problem hiding this comment.
Numbers here should not be hard coded but calculated from the constants (MAX_CALL_DEPTH * STACK_FRAME_SIZE).
There was a problem hiding this comment.
I can make a guesstimate of (MAX_CALL_DEPTH - 2) * STACK_FRAM_SIZE for here, but the truth is that estimating the number of zeroed bytes with STACK_FRAME_SIZE = 4096 is more intricate now, since stack frames have no predefined size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are three new SBPF versions already released in the platform tools that are compatible with the current validator configuration, but we do not test them actively in the CI.
Summary of Changes
programs/sbffolder Makefile.