Refactor ComputeBudget and ComputeBudgetLimits #5127
Draft
+620
−491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firedancer team maintains a line-for-line reimplementation of the |
pgarg66
force-pushed
the
compute-budget-cleanup
branch
7 times, most recently
from
574e7f9 to
bdf787f
Compare
- Move relevant structs into SVM boundaries
pgarg66
force-pushed
the
compute-budget-cleanup
branch
from
bdf787f to
a57aae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ComputeBudget and ComputeBudgetLimits usage in SVM could be cleaned up.
Summary of Changes
Refactor ComputeBudget and ComputeBudgetLimits
Fixes #