Maria Island long timeseries products #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbesnard @bpasquer @ggalibert This is ready for review and can be merged. (The script to create the NetCDF files will not work until #465 is merged.) |
|
@mhidas Could you please send me the mat file ? |
| print savedFile | ||
|
|
||
| G.close() | ||
|
|
There was a problem hiding this comment.
extra line.
Only have comments on a cosmetic side
- upper case variable instead of lower case, (Python coding style and consistency #283) for netcdf vars and F, G
- double empty lines in a row
Otherwise it makes sence
I imagine most of the nc file is set with inc.IMOSnetCDFFile(attribFile=attrib_file)
There was a problem hiding this comment.
Yes, that automatically adds the core IMOS attributes, plus what's specified in attrib_file.
I'll fix up the cosmetics.
mhidas
force-pushed
the
anmn_nrsmai_long_timeseries_product
branch
from
0a5dbf1 to
baf40d5
Compare
|
@lbesnard Thanks. I've renamed the netCDF objects. I think it makes sense to keep the variables in capitals ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON #465 . Please merge that PR first.