Hourly files created with no valid current data are ignored and not p… #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Return True if netcdf file includes at least 1 current measurement != NaN | ||
| retval = True | ||
| F = Dataset(nc_file, mode='r') | ||
| if F['UCUR'][:].mask.all() & F['VCUR'][:].mask.all(): |
There was a problem hiding this comment.
It may not make a difference in some cases, but I think you want the boolean operator and here.
& means bitwise AND.
…ntions and for clarity.
… in has_current_data() function.
|
Thanks for your feedback @mhidas . If you're happy with newly added commits to address your comments I will squash them into one. |
|
@ggalibert Looks good. Squash away! |
|
@ggalibert I let GitHub do the squashing. Hope you don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ushed to S3.