Platform n organisation vocabs (processing data from ARDC and populating vocabs index contents) #112
Conversation
vietnguyengit
changed the title
vietnguyengit
force-pushed
the
platform-n-organisation-search
branch
from
fa70f04
to
8b18177
Compare
| public void init() throws IOException { | ||
| // this could take a few minutes to complete, in development, you can skip it with -Dapp.initialiseVocabsIndex=false | ||
| // you can call /api/v1/indexer/ext/vocabs/populate endpoint to manually refresh the vocabs index, without waiting for the scheduled task |
There was a problem hiding this comment.
just want to highlight this
vietnguyengit
force-pushed
the
platform-n-organisation-search
branch
from
27c5e30
to
dc7e513
Compare
vietnguyengit
force-pushed
the
platform-n-organisation-search
branch
from
bcff355
to
fbc3b87
Compare
| assertTrue(parameterVocabs.stream().anyMatch(vocab -> vocab.equalsIgnoreCase("temperature"))); | ||
| assertTrue(parameterVocabs.stream().anyMatch(vocab -> vocab.equalsIgnoreCase("salinity"))); | ||
| assertTrue(parameterVocabs.stream().anyMatch(vocab -> vocab.equalsIgnoreCase("carbon"))); | ||
| assertTrue(parameterVocabs.stream().anyMatch(vocab -> vocab.equalsIgnoreCase("pH (total scale) of the water body"))); |
There was a problem hiding this comment.
so this might affect the UI design to display phrase-like selecting options
the second-level vocabs are not always short words, the current implementation to process ardc vocabs has bug overlooking vocabs that don't have leaf nodes (bottom-level).
I manually inspected the ardc apis to verify this, the current prod portal also has "pH (total scale) of the water body"
There was a problem hiding this comment.
Well I am a bit lost on what you mean, is this a requirement ?
There was a problem hiding this comment.
no I meant what we currently have for parameter vocab has bug, this current PR you're reviewing will fix that.
the bug missed identifying some second-level vocabs
There was a problem hiding this comment.
and because some of them are very long, not just 1 or 2 words, when it appears in the new portal
in particular, here:
it may look ugly?
There was a problem hiding this comment.
e.g pH (total scale) of the water body has never been identified as second-level vocab (which should be, its parent node is Chemical) until this PR.
| String about = vocabNode.getAbout(); | ||
| if (about != null && !about.isEmpty()) { | ||
| resourceUri = about; | ||
| } |
There was a problem hiding this comment.
risk getting null pointer exception here, I'll change to
if (vocabNode.getAbout() != null && !vocabNode.getAbout().isEmpty()) {
resourceUri = vocabNode.getAbout();
}There was a problem hiding this comment.
use safeGet() as much as you can it is easier
There was a problem hiding this comment.
will do altogether after the PR view
…ocabLabelsFromThemes method
…ocabLabelsFromThemes method
vietnguyengit
force-pushed
the
platform-n-organisation-search
branch
from
cdf6863
to
d4141f8
Compare
vietnguyengit
force-pushed
the
platform-n-organisation-search
branch
from
d4141f8
to
443acfd
Compare
vietnguyengit
force-pushed
the
platform-n-organisation-search
branch
from
5051ec6
to
9e7e7ed
Compare
|
Please close this one as replace by this #130 |
No description provided.