Extra labels organisation vocabs #151
Conversation
| default -> new ArrayList<>(); | ||
| }; | ||
| if (vocabType.equals(AppConstants.AODN_ORGANISATION_VOCABS)) { | ||
| // TODO: the logics for mapping record's organisation vocabs are heavily customised for a manual approach, AI now or later? |
There was a problem hiding this comment.
should I do it the old school if-else, or leave here empty for Yuxuan's future magic? @utas-raymondng
There was a problem hiding this comment.
How complicate the logic will be, for simple one if-else makes more sense
| if (!processedOrganisationVocabs.isEmpty()) { | ||
| stacCollectionModel.getSummaries().setOrganisationVocabs(processedOrganisationVocabs); | ||
| } | ||
| // TODO: the logics for mapping record's organisation vocabs are heavily customised for a manual approach, AI now or later? need dedicated service's method |
There was a problem hiding this comment.
will not using extractVocabLabelsFromThemes method for organisation vocabs, the record's vocabs are found in different fields of the records, not "themes"
| if (labelNode instanceof TextNode) { | ||
| return labelNode.asText(); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
I think needed, there is case that the node is just a plain text, where also case it is a json-like
E.g node = "test" vs node = {"_value": "sample"}
@utas-raymond
There was a problem hiding this comment.
In particular, that line for textNode stuff helps to extract "displayLabel" , without it, can't get 'displayLabel' like with "prefLabel" you previous familiar with, no "_value" field.
There was a problem hiding this comment.
I mean there is already a return null at the end, hence if non of the if hit then it will already return null?
| if (labelNode instanceof TextNode) { | ||
| return labelNode.asText(); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
I mean there is already a return null at the end, hence if non of the if hit then it will already return null?
No description provided.