Feature/5972 index downloaded data #162
Conversation
# Conflicts: # indexer/src/test/java/au/org/aodn/esindexer/service/StacCollectionMapperServiceTest.java
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| public interface AppConstants { | |||
| String PORTAL_RECORDS_MAPPING_JSON_FILE = "portal_records_index_schema.json"; | |||
| String DTASET_INDEX_MAPPING_JSON_FILE = "dataset_index_schema.json"; | |||
| @Configuration | ||
| public class DatasetAccessConfig { | ||
|
|
||
| @Bean(name = "DatasetAccessService") |
There was a problem hiding this comment.
The repo is data-access-service, maybe you call it the same way, DataAccessService, be less varied in names.
| public class DatasetAccessConfig { | ||
|
|
||
| @Bean(name = "DatasetAccessService") | ||
| public DatasetAccessServiceImpl createDatasetAccessService( |
There was a problem hiding this comment.
Same, dataset to data.
|
|
||
| @Bean(name = "DatasetAccessService") | ||
| public DatasetAccessServiceImpl createDatasetAccessService( | ||
| @Value("${dataaccess.host:defaulthost}") String serverUrl |
There was a problem hiding this comment.
dataAccessSevice.host.default
Host then also defaultHost, not necessary
| @@ -33,6 +38,9 @@ public class IndexerController { | |||
| @Autowired | |||
| GeoNetworkService geonetworkResourceService; | |||
|
|
|||
| @Autowired | |||
| DatasetAccessService datasetAccessService; | |||
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| public interface DatasetAccessService { |
| // TODO: if more fields are needed to be filtered, please add more columns here | ||
| @Getter | ||
| @Setter | ||
| public class DataRecord{ |
There was a problem hiding this comment.
I think they all need to reconsider a clearer and consistent name, to be less confusing,
As is growing, the terms
: data record, metadata record, data, dataset etc.
What are they? Are they the same thing or different?
| .buildAndExpand(uuid) | ||
| .toUriString(); | ||
|
|
||
| ResponseEntity<DataRecord[]> responseEntity = restTemplate.exchange( |
There was a problem hiding this comment.
DataRecord is a Dto? Then you should rename the model class to make it clear, with Dto postfix.
There was a problem hiding this comment.
Get....Dto, eg GetDataRecordDto
Create....Dto, e.g CreateDataRecordDto
There was a problem hiding this comment.
ah, it is not a standard DTO. Maybe i should rename DataRecord into AggregatedDatum, to express it is a single datum of a dataset with aggregated count
There was a problem hiding this comment.
or maybe just Datum?
Doesn't include "indexAll" api yet;
Doesn't have unit tests for new added features yet;