Add reducer support #169
Merged
Add reducer support #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // to reduce processing time. | ||
| @Getter | ||
| @Setter | ||
| protected static Double reducerPrecision = null; | ||
|
|
||
| // Load a coastline shape file so that we can get a spatial extents that cover sea only | ||
| public static void init() { |
There was a problem hiding this comment.
I feel like this class is growing bigger and bigger and its readability is somehow affected. It has quite a lot of static methods too. Maybe can refactor / group narrower scope's related methods into separate classes (like saveResourceToTemp is not really directly related to "geometry") and use dependency injection and reduce the size of GeometryUtils?
There was a problem hiding this comment.
Ok let me move this out
| @@ -75,7 +88,7 @@ public static void init() { | |||
| Geometry simplifiedGeometry = DouglasPeuckerSimplifier | |||
| .simplify(landFeatureGeometry, getCoastalPrecision()); // Adjust tolerance | |||
|
|
|||
| geometries.add(simplifiedGeometry); | |||
| geometries.add(reducer != null ? reducer.reduce(simplifiedGeometry) : simplifiedGeometry); | |||
There was a problem hiding this comment.
added a test case
vietnguyengit
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.