Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python notebooks cleaning #33

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

python notebooks cleaning #33

wants to merge 6 commits into from

Conversation

diodon
Copy link
Contributor

@diodon diodon commented Jun 12, 2024

python notebook testing and cleaning. README added

@diodon diodon requested a review from juliayun23 June 12, 2024 04:26
Copy link

@juliayun23 juliayun23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I'd like to suggest two small changes:

  1. There are still links pointing to staging sites. Might be a good opportunities to do a find&replace within this repository to make sure that there are all removed/updated.
  2. From a consistent format point of view, can you make sure the names of the notebooks all follow the same format? For example use the format: number-Camel_Case.ipynb (e.g. 02-Extracting_Spatial_Data_GBR_Features.ipynb).

"\n",
"We first connect to the metadata API by retrieving the root catalog\n",
"\n",
"To do this, you will need to go to https://dashboard.staging.reefdata.io/ and copy your Authentication token.\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diodon diodon marked this pull request as draft June 13, 2024 00:17
@diodon diodon marked this pull request as ready for review June 13, 2024 00:26
@diodon diodon requested a review from juliayun23 June 13, 2024 00:26
@juliayun23
Copy link

Nice work!

I'd like to suggest two small changes:

  1. There are still links pointing to staging sites. Might be a good opportunities to do a find&replace within this repository to make sure that there are all removed/updated.
  2. From a consistent format point of view, can you make sure the names of the notebooks all follow the same format? For example use the format: number-Camel_Case.ipynb (e.g. 02-Extracting_Spatial_Data_GBR_Features.ipynb).

@diodon Could you address the second point too?

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants