Pin path migration #103
Pin path migration #103
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #103 +/- ##
===========================================
- Coverage 87.61% 86.43% -1.18%
===========================================
Files 43 39 -4
Lines 3092 5139 +2047
Branches 225 404 +179
===========================================
+ Hits 2709 4442 +1733
- Misses 383 697 +314 ☔ View full report in Codecov by Sentry. |
src/config/config.cpp
Outdated
| { | ||
| MigrationConfig config {}; | ||
|
|
||
| config.mMigrationPath = migration.GetValue<std::string>("migrationPath"); | ||
| config.mMergedMigrationPath = migration.GetValue<std::string>("mergedMigrationPath"); | ||
|
|
||
| for (const auto& moduleConfig : moduleConfigs) { | ||
| aos::common::utils::CaseInsensitiveObjectWrapper object( | ||
| moduleConfig.mParams.extract<Poco::JSON::Object::Ptr>()); |
There was a problem hiding this comment.
There's a constructor that accepts poco dynamic var that does extract in the implementation:
CaseInsensitiveObjectWrapper::CaseInsensitiveObjectWrapper(const Poco::Dynamic::Var& var)
| moduleConfig.mParams.extract<Poco::JSON::Object::Ptr>()); | |
| ); |
There was a problem hiding this comment.
good. thank you. changed
src/database/database.cpp
Outdated
| CreateMigrationData(migration); | ||
| mMigration->MigrateToVersion(GetVersion()); | ||
| DropMigrationData(); | ||
| } catch (const Poco::Exception& e) { |
There was a problem hiding this comment.
Please use unified version:
| } catch (const Poco::Exception& e) { | |
| catch (const std::exception& e) { | |
| return utils::ToAosError(e); | |
| } |
tests/database/database_test.cpp
Outdated
| } | ||
|
|
||
| /** | ||
| void Migration::CreateVersionTable() |
There was a problem hiding this comment.
delete this code if not needed
tests/database/database_test.cpp
Outdated
| now; | ||
| } | ||
|
|
||
| */ |
There was a problem hiding this comment.
sure, done.
Signed-off-by: Mykola Kobets <[email protected]>
mykola-kobets-epam
force-pushed
the
pin-path-migration
branch
from
ee8bd1e to
f15cd5a
Compare
Signed-off-by: Mykola Kobets <[email protected]>
mykola-kobets-epam
force-pushed
the
pin-path-migration
branch
from
f15cd5a to
4ba0f10
Compare
|
No description provided.