Start instance monitoring before instance is launched #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
===========================================
- Coverage 86.56% 84.49% -2.07%
===========================================
Files 85 155 +70
Lines 7448 13540 +6092
Branches 0 1675 +1675
===========================================
+ Hits 6447 11441 +4994
- Misses 1001 2099 +1098 ☔ View full report in Codecov by Sentry. |
mlohvynenko
force-pushed
the
feature_early_start_monitoring
branch
from
ec4530d to
d6f2278
Compare
mlohvynenko
changed the title
mlohvynenko
changed the title
al1img
reviewed
Jan 31, 2025
mlohvynenko
force-pushed
the
feature_early_start_monitoring
branch
from
1cb503e to
2afe68a
Compare
mykola-kobets-epam
approved these changes
Feb 3, 2025
…on start Signed-off-by: Mykhailo Lohvynenko <[email protected]>
mlohvynenko
force-pushed
the
feature_early_start_monitoring
branch
3 times, most recently
from
c62f54c to
e6b8059
Compare
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
mlohvynenko
force-pushed
the
feature_early_start_monitoring
branch
from
e6b8059 to
8056108
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceMonitor::ProcessMonitoring() runs on a separate thread and operates with a delay defined by the "poll period" configuration variable.
As a result, ProcessMonitoring() may execute at a moment when instance monitoring has started, but the instance itself has not yet been launched, leading to the following error:
main aos_servicemanager[1659]: (monitoring) Failed to get instance monitoring data: not found (resourceusageprovider.cpp:324)