Implement apr_shm_perms_set for POSIX shm_open/"classic mmap" shmem #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
notroj
commented
Aug 6, 2024
notroj
commented
POSIX shm case and "classic mmap" case.
* test/testshm.c (test_named_perms): Add test case.
CI: Add tests for various SHM configurations, and that the decision
logic is setting the correct APR_USE_SHM_* variables.
notroj
force-pushed
the
posix-shm-set-perms
branch
from
b509853
to
cdcffc1
Compare
notroj
changed the title
rpluem
reviewed
Aug 7, 2024
Co-authored-by: Ruediger Pluem <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 8, 2024
* test/testshm.c (test_named_perms): Add test case.
* shmem/unix/shm.c (APR_PERMS_SET_IMPLEMENT): Implement for the POSIX
shm and "classic mmap" cases.
CI: Add tests for various SHM configurations, and that the decision
logic is setting the correct APR_USE_SHM_* variables.
* test/testshm.c (test_named_perms): Skip on Mac OS X, hangs in CI
and fails manually, see dev@apr msgid <CALK=YjNNbfcTcxKm4YiVGS+1aOPTaL3-c8TqhWZLqkyR0PRWVg@mail.gmail.com>.
Submitted by: jorton, rpluem
Github: closes #59
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/branches/1.8.x@1919739 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Aug 20, 2024
* test/testshm.c (test_named_perms): Add test case.
* shmem/unix/shm.c (APR_PERMS_SET_IMPLEMENT): Implement for the POSIX
shm and "classic mmap" cases.
CI: Add tests for various SHM configurations, and that the decision
logic is setting the correct APR_USE_SHM_* variables.
* shmem/unix/shm.c (apr_shm_perms_set): Omit the POSIX shm
implementation on MacOS (falling through to ENOTIMPL instead), since
it is either failing or hanging in testing.
See https://lists.apache.org/thread/1gj7j8h0nxlly2j2gnrbh6m7sy4o0fob
Submitted by: jorton, rpluem
Github: closes #59
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/branches/1.7.x@1920062 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.