Install required node modules and ruby gems #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need newer versions than in existing images
kou
reviewed
Jan 7, 2024
| - name: Install Ruby and nodejs | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y npm ruby ruby-dev |
There was a problem hiding this comment.
Why do we need to use apt-get install instead of setup-* actions?
We can update Ruby version by https://github.com/apache/arrow-site/blob/main/.ruby-version and Node.js version by https://github.com/apache/arrow-site/blob/main/.nvmrc .
|
Prefer #453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need newer versions than in existing images
As compared to #453 baseurl is not set. Only merge one of the two, I think it is preferable to have baseurl. Site can be previewed at https://bkmgit.github.io/arrow-site/ from preview generated at bkmgit#3